Repository navigation
Fix coloring of methods and add throughput lines in network vs runtime plots - #201
Merged
Merged
Conversation
oruebel
commented
Oct 5, 2026
oruebel
commented
Contributor
- The colors for different methods were chosen within each function, which led to inconsistent colors in particular when select methods were for some reason missing in a plot. This PR adds a fixed color palette to ensure consistent assignment of colors to methods across all plots.
- Add throughput (MB/s) lines to the plots showing the network traffic vs runtime
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Fallback colors remain subset-dependent, and throughput guides misrepresent non-byte metrics.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Standardizes method colors across benchmark plots and adds throughput references to network-traffic-versus-runtime visualizations.
Changes:
- Adds a shared method palette across plot types.
- Adds dashed throughput guides, captions, and adjusted titles.
| File | Description |
|---|---|
src/nwb_benchmarks/database/_visualization.py |
Centralizes method colors and adds throughput overlays. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
|
One minor recommendation, either/or:
|
Collaborator
|
@oruebel ping on these suggestions; happy to make them directly if you prefer |
Contributor
Author
sure, feel free to add them directly |
… version (follow-up to #201) (#215) Applies both suggestions from [#201](#201 (comment)), which @oruebel agreed to in [this comment](#201 (comment)). Targets the `fix_method_colors` branch so it folds into #201. - Swap `#9467BD` (purple) for `#8C510A` (dark brown) as the color of `zarr s3 force no consolidated`, so it differs from the yellow of `zarr s3` in brightness as well as hue. The `pynwb` variant picks up the same color through the existing derived mapping. - Tell the unconsolidated Zarr variant apart from `zarr s3` by line style and marker as well: it is drawn dash-dot with square markers (new `DEFAULT_METHOD_LINESTYLES` / `DEFAULT_METHOD_MARKERS` next to `DEFAULT_METHOD_COLORS`, with the same PyNWB derivation). Applied in every plot that connects points per method: the slicing and file-open network-vs-runtime plots (legend handles included), the slice-size and performance-over-versions point plots via seaborn's `markers` / `linestyles`, and the download-vs-stream extrapolation lines. Dash-dot rather than dashed so the variant does not collide with the dashed gray throughput guide lines added in #201. - Bump the package version to `0.2.2` (main is now at `0.2.1` after #210), since #201 changes code under `src/nwb_benchmarks/` and its `version-check` CI run is currently failing for the missing bump (patch bump per `AGENTS.md`: a fix that leaves what the benchmarks measure alone). Smoke-tested each changed plot path on synthetic data; `black` and `isort` pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01E6ccBQPZ1RBwpZvme23B2t --------- Co-authored-by: Claude <noreply@anthropic.com>
CodyCBakerPhD
approved these changes
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.